Skip to content

chore: upgrade dependencies with critical and high vulnerabilities#2547

Open
mburri wants to merge 13 commits intomainfrom
chore/upgrade-dependencies-prio-0
Open

chore: upgrade dependencies with critical and high vulnerabilities#2547
mburri wants to merge 13 commits intomainfrom
chore/upgrade-dependencies-prio-0

Conversation

@mburri
Copy link
Copy Markdown
Contributor

@mburri mburri commented Apr 14, 2026

This PR contains a first batch of dependency lifecycles with a focus on critical vulnerablities.

Upgrades include:

Other changes:

  • the version of rollup had some vulnerabilites - instead of upgrading it I decided to rewrite the task where rollup was used to use esbuild. This decision was made, because the existing process to build the embed.js file was also dependent on the babel.config.js file. If we want to switch to swc and turbopack (default with next 16) we will have to get rid of this anyway.
  • the npm publish task used the @preconstruct/cli dependency and also used the babel config file. @preconstruct/cli had lots of high and critical issues. Since there seems to be little value to publish the app as an npm package, this task was removed without a replacement.

Fixing critical vulnerabilites using package resolutions

After the first few upgrades it became apparent that the critical vulnerabilites could not be addressed in this way, because most of them were included in the project as transitive dependencies of multiple packages. It would have just taken too long for this first iteration. With assistance of a coding AI, it was decided to enforce patched versions of the affected packages by the resolutions property in package.json:

"resolutions": {
    "@babel/core": "^7.26.0",
    "@babel/parser": "^7.26.0",
    "@babel/traverse": "^7.23.2",
    "minimist": "^1.2.6",
    "pbkdf2": "^3.1.3",
    "sha.js": "^2.4.12",
    "cipher-base": "^1.0.5",
    "handlebars": "^4.7.9",
    "elliptic": "^6.6.1",
    "form-data": "^4.0.4",
    "fast-xml-parser": "^5.5.12"
  },

This fixed all critical vulnerabilites in one go while not breaking performance or e2e tests.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
visualization-tool Ready Ready Preview, Comment Apr 15, 2026 0:25am

Request Review

Copy link
Copy Markdown
Contributor

@ludovicm67 ludovicm67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.

We just need to make sure to not forget to remove the "resolution" part in a later step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants