chore: upgrade dependencies with critical and high vulnerabilities#2547
Open
chore: upgrade dependencies with critical and high vulnerabilities#2547
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
922d070 to
07e2102
Compare
80940fe to
3b6d776
Compare
also: replace bun in script task
3b6d776 to
ee6cc6e
Compare
ludovicm67
approved these changes
Apr 15, 2026
Contributor
ludovicm67
left a comment
There was a problem hiding this comment.
Looks good for me.
We just need to make sure to not forget to remove the "resolution" part in a later step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a first batch of dependency lifecycles with a focus on critical vulnerablities.
Upgrades include:
Other changes:
rolluphad some vulnerabilites - instead of upgrading it I decided to rewrite the task where rollup was used to useesbuild. This decision was made, because the existing process to build the embed.js file was also dependent on the babel.config.js file. If we want to switch to swc and turbopack (default with next 16) we will have to get rid of this anyway.npm publishtask used the@preconstruct/clidependency and also used the babel config file.@preconstruct/clihad lots of high and critical issues. Since there seems to be little value to publish the app as an npm package, this task was removed without a replacement.Fixing critical vulnerabilites using package resolutions
After the first few upgrades it became apparent that the critical vulnerabilites could not be addressed in this way, because most of them were included in the project as transitive dependencies of multiple packages. It would have just taken too long for this first iteration. With assistance of a coding AI, it was decided to enforce patched versions of the affected packages by the
resolutionsproperty inpackage.json:This fixed all critical vulnerabilites in one go while not breaking performance or e2e tests.